This is the mail archive of the
mailing list for the GDB project.
Re: MinGW compilation warnings in libiberty's include/environ.h
- From: DJ Delorie <dj at redhat dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: gcc-patches at gcc dot gnu dot org, gdb-patches at sourceware dot org
- Date: Fri, 19 May 2017 21:25:56 -0400
- Subject: Re: MinGW compilation warnings in libiberty's include/environ.h
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dj at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 902F480468
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 902F480468
Fix committed. As Pedro noted, the correct way to request a change is
to make the change in your local checked out repo, and run "svn diff"
(or "git diff"). That makes sure that the fix is what you intended, and
that you don't have other unexpected changes (especially in regenerated
files, like configure). It also checks against a patch against a stale
copy of the sources; if your patch doesn't apply that's a hint to the
maintainer that the patch needs to be looked at more closely.
The easier you can make it for the maintainer (me!), the more likely
your patch will get handled quickly.