This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: GDB 7.99.91 MinGW compilation warning in tui.c

On 05/19/2017 01:51 PM, Eli Zaretskii wrote:

> No.  The patches are there, they are just not in the Diff format.

A description of a patch is not a patch, in my book.

>  I
> don't have write access to the GCC repository anyway, so describing a
> bunch of simple patches sounded appropriate.  And since no one
> responded, I'm not sure it's worth my while to make any further
> efforts.

"A picture is worth a thousand words" kind of applies to patches too.
You seem to assume that someone would take the descriptions you
gave, turn them into actual code, make sure things still compile
on their favorite host plus that it actually fixes what it's supposed
to fix on MinGW, write some ChangeLogs, etc.  And maybe what you
describe as simple turns out to not be so simple, etc.  Others will be
wondering whether it'll be worth their efforts to engage too, especially
those that don't use Windows which I think is the vast majority in
these circles.  If you attach/post a real diff/patch, showing exactly
and unambiguously what it is that what you want to get in, then I
expect you'd get quicker attention.

You've asked

  "Should I just go ahead and fix our copy of libiberty?"

So you've already implied that you'd do the work to
actually write the patch and the ChangeLogs.  

So I don't understand the reluctance of posting an actual diff
to gcc-patches.

Pedro Alves

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]