This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb passes and returns incorrect values when dealing with small array on Sparc
- From: Pedro Alves <palves at redhat dot com>
- To: "Jose E. Marchesi" <jose dot marchesi at oracle dot com>, vladimir dot mezentsev at oracle dot com
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 19 May 2017 10:57:52 +0100
- Subject: Re: [PATCH] gdb passes and returns incorrect values when dealing with small array on Sparc
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8706B7AE95
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8706B7AE95
- References: <1494950959-42849-1-git-send-email-vladimir.mezentsev@oracle.com> <87shk1mb99.fsf@oracle.com>
On 05/19/2017 10:44 AM, Jose E. Marchesi wrote:
>
> From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
>
> gdb has a special type (TYPE_CODE_ARRAY) to support the gcc extension
> (https://gcc.gnu.org/onlinedocs/gcc/Vector-Extensions.html).
> TYPE_CODE_ARRAY is handled incorrectly for both (32- and 64-bit) modes on Sparc machines.
>
> Tested on sparc64-linux-gnu and sparc-solaris (32- and 64-bit mode).
> No regressions.
>
> gdb/ChangeLog:
> 2017-05-12 Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
>
> * sparc-tdep.c (sparc_structure_return_p)
> (sparc_arg_on_registers_p): New functions.
> (sparc32_store_arguments): Use them.
> * sparc64-tdep.c (sparc64_16_byte_align_p)
> (sparc64_store_floating_fields, sparc64_extract_floating_fields):
> Handle TYPE_CODE_ARRAY.
>
>
> LGTM. Ok for master?
>
OK with the commit log tweak mentioned at:
https://sourceware.org/ml/gdb-patches/2017-04/msg00509.html
Thanks,
Pedro Alves