This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 1/3] gdb.base/fileio.exp: Remove nowarnings
- From: Pedro Alves <palves at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Thu, 18 May 2017 12:09:05 +0100
- Subject: [PATCH 1/3] gdb.base/fileio.exp: Remove nowarnings
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9AA7980E7C
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9AA7980E7C
- References: <9eedfbd7-9f36-2fe4-7a13-00e0b2261629@redhat.com>
... and quiet -Wnonnull in a different way.
gdb/testsuite/ChangeLog:
2017-05-18 Pedro Alves <palves@redhat.com>
* gdb.base/fileio.c (null_str): New global.
(test_stat): Use it.
* gdb.base/fileio.exp: Remove nowarnings.
---
gdb/testsuite/gdb.base/fileio.c | 6 +++++-
gdb/testsuite/gdb.base/fileio.exp | 2 +-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/gdb/testsuite/gdb.base/fileio.c b/gdb/testsuite/gdb.base/fileio.c
index e443173..38537db 100644
--- a/gdb/testsuite/gdb.base/fileio.c
+++ b/gdb/testsuite/gdb.base/fileio.c
@@ -76,6 +76,10 @@ static const char *strerrno (int err);
static void stop () {}
+/* A NULL string. We pass this to stat below instead of a NULL
+ literal to avoid -Wnonnull warnings. */
+const char *null_str;
+
int
test_open ()
{
@@ -294,7 +298,7 @@ test_stat ()
stop ();
/* NULL pathname */
errno = 0;
- ret = stat (NULL, &st);
+ ret = stat (null_str, &st);
printf ("stat 2: ret = %d, errno = %d %s\n", ret, errno,
strerrno (errno));
stop ();
diff --git a/gdb/testsuite/gdb.base/fileio.exp b/gdb/testsuite/gdb.base/fileio.exp
index 14aaa0d..6bb7141 100644
--- a/gdb/testsuite/gdb.base/fileio.exp
+++ b/gdb/testsuite/gdb.base/fileio.exp
@@ -31,7 +31,7 @@ if {[is_remote host]} {
if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" \
executable \
- [list debug nowarnings "additional_flags=-DOUTDIR=\"$outdir/\""]] != "" } {
+ [list debug "additional_flags=-DOUTDIR=\"$outdir/\""]] != "" } {
untested "failed to compile"
return -1
}
--
2.5.5