This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: Document vMustReplyEmpty remote packet
- From: Pedro Alves <palves at redhat dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, gdb-patches at sourceware dot org
- Date: Wed, 17 May 2017 13:48:01 +0100
- Subject: Re: [PATCH] gdb: Document vMustReplyEmpty remote packet
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 83AFF61BA6
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 83AFF61BA6
- References: <1494840778-18726-1-git-send-email-andrew.burgess@embecosm.com>
On 05/15/2017 10:32 AM, Andrew Burgess wrote:
> Add mention of the vMustReplyEmpty to the remote serial protocol
> documentation. It is important that this packet be treated in the same
> fashion as any other unknown 'v' packet, and I have tried to reflect
> this in the description of the packet, it is not simply the case that we
> _must_ return the empty string for this packet.
>
> As the intention is that we should treat this packet as unknown then an
> argument could be made that we should not document it, however, for
> someone implementing a gdbserver from scratch, seeing an undocumented
> packet arrive from gdb is confusing, and will probably cause them to
> have to read the code in order to check how this packet should be
> handled, which is not ideal.
>
> gdb/doc/ChangeLog:
>
> * gdb.texinfo (Packets): Document vMustReplyEmpty packet.
This is fine with me.
Thanks,
Pedro Alves