This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 03/19] PR gdb/21226: Take DWARF stack value pieces from LSB end


Andreas Arnez <arnez@linux.vnet.ibm.com> writes:

> I mean this part of the logic:
>
> 	    if (n > c->addr_size - source_offset)
> 	      n = (c->addr_size >= source_offset
> 		   ? c->addr_size - source_offset
> 		   : 0);
> 	    if (n == 0)
> 	      {
> 		/* Nothing.  */
> 	      }
>             else ...
>
> Which can essentially be translated into
>
> 	    if (n == 0 || source_offset >= c->addr_size)
> 	      break;
> 	    ...

OK, I see what you mean now.  The patch is good to me.

-- 
Yao (齐尧)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]