This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 04/19] Remove addr_size field from struct piece_closure

From: Yao Qi <qiyaoltc at gmail dot com>
To: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
Cc: gdb-patches at sourceware dot org
Date: Thu, 11 May 2017 22:29:08 +0100
Subject: Re: [PATCH v2 04/19] Remove addr_size field from struct piece_closure
Authentication-results: sourceware.org; auth=none
References: <1494352015-10465-1-git-send-email-arnez@linux.vnet.ibm.com> <1494352015-10465-5-git-send-email-arnez@linux.vnet.ibm.com>

On 17-05-09 19:46:00, Andreas Arnez wrote:
> The addr_size field in the piece_closure data structure is a relic from
> before introducing the typed DWARF stack.  It is obsolete now.  This patch
> removes it.
> 
> gdb/ChangeLog:
> 
> 	* dwarf2loc.c (struct piece_closure) <addr_size>: Remove field.
> 	(allocate_piece_closure): Drop addr_size parameter.
> 	(dwarf2_evaluate_loc_desc_full): Adjust call to
> 	allocate_piece_closure.

It is obvious, patch is good to me.

-- 
Yao

References:
- [PATCH v2 00/19] Various DWARF piece fixes
  - From: Andreas Arnez
- [PATCH v2 04/19] Remove addr_size field from struct piece_closure
  - From: Andreas Arnez

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]