This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 1/2] Introduce "gdb/configure.nat" (and delete "gdb/config/*/*.mh" files)
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Simon Marchi <simon dot marchi at polymtl dot ca>, John Baldwin <jhb at freebsd dot org>
- Date: Sat, 06 May 2017 10:13:20 -0400
- Subject: Re: [PATCH v3 1/2] Introduce "gdb/configure.nat" (and delete "gdb/config/*/*.mh" files)
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A1A3E64450
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A1A3E64450
- References: <20170425202309.15771-1-sergiodj@redhat.com> <20170505042951.32097-1-sergiodj@redhat.com> <20170505042951.32097-2-sergiodj@redhat.com> <dbba7539-3f52-bfd3-3f69-8d6d34ac0f36@redhat.com>
On Friday, May 05 2017, Pedro Alves wrote:
> On 05/05/2017 05:29 AM, Sergio Durigan Junior wrote:
>
>> +# Native-target dependent makefile fragment comes in here.
>> +@nat_extra_makefile_frag@
>> +
>
>> rename from gdb/config/i386/i386gnu.mh
>> rename to gdb/config/i386/i386gnu-extra.mh
>> index 070497f..93016ff 100644
>> --- a/gdb/config/i386/i386gnu.mh
>> +++ b/gdb/config/i386/i386gnu-extra.mh
>
> ...
>
>> # MIG stubs are not yet ready for C++ compilation.
>> -%_S.o %_U.o : COMPILE.post += -x c
>> +%_S.o %_U.o : COMPILE.post +=-x c
>>
>
> Spurious whitespace change.
>
>> NAT_GENERATED_FILES = notify_S.h notify_S.c \
>> - process_reply_S.h process_reply_S.c \
>> - msg_reply_S.h msg_reply_S.c msg_U.h msg_U.c \
>> - exc_request_U.h exc_request_U.c exc_request_S.h exc_request_S.c
>> + process_reply_S.h process_reply_S.c \
>> + msg_reply_S.h msg_reply_S.c msg_U.h msg_U.c \
>> + exc_request_U.h exc_request_U.c exc_request_S.h exc_request_S.c
>
> Ditto.
>
> Apart from the naming issue and the spurious whitespace changes,
> this looks fine to me.
Thanks, pushed with the nits addressed.
21ea5acdd1bcfe89984b16b5bac730050c5cf05e
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/