This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v6 4/4] Implement proper "startup-with-shell" support on gdbserver
- From: Pedro Alves <palves at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>, GDB Patches <gdb-patches at sourceware dot org>
- Date: Fri, 5 May 2017 20:21:47 +0100
- Subject: Re: [PATCH v6 4/4] Implement proper "startup-with-shell" support on gdbserver
- Authentication-results: sourceware.org; auth=none
- References: <1482464361-4068-1-git-send-email-sergiodj@redhat.com> <20170504052954.16936-1-sergiodj@redhat.com> <20170504052954.16936-5-sergiodj@redhat.com>
On 05/04/2017 06:29 AM, Sergio Durigan Junior wrote:
> --- a/gdb/gdbserver/server.c
> +++ b/gdb/gdbserver/server.c
> @@ -877,6 +877,31 @@ handle_general_set (char *own_buf)
> return;
> }
>
> + if (startswith (own_buf, "QStartupWithShell:"))
> + {
> + char *value = own_buf + strlen ("QStartupWithShell:");
const.
> +set unique_file [standard_output_file "unique-file.unique-extension"]
> +set unique_file_dir [standard_output_file ""]
> +
> +run_on_host "touch $unique_file" "touch" "$unique_file"
> +
This may require some tweaking or disabling when tested against
a remote host. Not sure. Could you check whether the test runs
with testsuite/boards/local-remote-host-native.exp?
Otherwise this one LGTM.
Thanks,
Pedro Alves