This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/4] Consistently use fprintf_filtered when displaying MIPS registers.
- From: Pedro Alves <palves at redhat dot com>
- To: Luis Machado <lgustavo at codesourcery dot com>, John Baldwin <jhb at FreeBSD dot org>, gdb-patches at sourceware dot org
- Date: Thu, 27 Apr 2017 17:05:33 +0100
- Subject: Re: [PATCH 3/4] Consistently use fprintf_filtered when displaying MIPS registers.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D6CD161982
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D6CD161982
- References: <20170412183727.22483-1-jhb@FreeBSD.org> <20170412183727.22483-4-jhb@FreeBSD.org> <8eadfc97-f4ec-8c89-f193-f96a2fa8839c@codesourcery.com>
On 04/13/2017 05:29 PM, Luis Machado wrote:
> On 04/12/2017 01:37 PM, John Baldwin wrote:
>> One line was using printf_filtered instead of fprintf_filtered
>> to the requested file.
>>
>> gdb/ChangeLog:
>>
>> * mips-tdep.c (print_gp_register_row): Replace printf_filtered
>> with fprintf_filtered.
>> ---
>> gdb/ChangeLog | 5 +++++
>> gdb/mips-tdep.c | 2 +-
>> 2 files changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
>> index 73d24d2c9d..f1ac925fec 100644
>> --- a/gdb/ChangeLog
>> +++ b/gdb/ChangeLog
>> @@ -1,5 +1,10 @@
>> 2017-04-11 John Baldwin <jhb@FreeBSD.org>
>>
>> + * mips-tdep.c (print_gp_register_row): Replace printf_filtered
>> + with fprintf_filtered.
>> +
>> +2017-04-11 John Baldwin <jhb@FreeBSD.org>
>> +
>> * mips-fbsd-tdep.c (MIPS_PC_REGNUM): Remove.
>> (MIPS_FP0_REGNUM): Remove.
>> (MIPS_FSR_REGNUM): Remove.
>> diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c
>> index 41cb9d82c6..674b5098b0 100644
>> --- a/gdb/mips-tdep.c
>> +++ b/gdb/mips-tdep.c
>> @@ -6539,7 +6539,7 @@ print_gp_register_row (struct ui_file *file,
>> struct frame_info *frame,
>> for (byte = 0;
>> byte < (mips_abi_regsize (gdbarch)
>> - register_size (gdbarch, regnum)); byte++)
>> - printf_filtered (" ");
>> + fprintf_filtered (file, " ");
>> /* Now print the register value in hex, endian order. */
>> if (gdbarch_byte_order (gdbarch) == BFD_ENDIAN_BIG)
>> for (byte =
>>
>
> This one seems trivial enough. I have no comments.
Agreed. This one's obviously correct. Please push it in.
Thanks,
Pedro Alves