This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 00/10] various frame filter fixes and cleanups
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Thu, 27 Apr 2017 09:58:43 +0100
- Subject: Re: [RFA 00/10] various frame filter fixes and cleanups
- Authentication-results: sourceware.org; auth=none
- References: <20170425194113.17862-1-tom@tromey.com>
On 25/04/17 20:41, Tom Tromey wrote:
> This series fixes a few frame filter bugs. Some of them have been
> reported, but some not.
>
> There are some documentation changes in patch #1 and patch #3.
>
> For the most part I think each patch is reasonably self-explanatory.
> However, there are a couple of things to note here:
>
> * You might wonder about the choice of constant in patch #3. I chose
> 32 rather than 16 so as not to conflict with my earlier frame-filter
> patch, in review.
>
> * In some cases writing a test seemed pretty difficult, and also maybe
> low-impact, so I didn't. This applies to patch #6, #9, and #10.
>
> A future direction for patch #3 would be to add a new "set" command so
> that a user can choose "bt elide" as the default.
>
> Tested on the buildbot.
I've looked through the patches and nothing stands out (beyond the minor nits pointed out already). I'd like to make the case that this be an inclusion for GDB 8. It's a series of very nice bugfixes for some long standing issues. It might be too late in the day for this, though. What does everyone else think?
Cheers
Phil