This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH v3 3/8] Python: Remove ptid from gdb.Record interface
- From: Tim Wiederhake <tim dot wiederhake at intel dot com>
- To: gdb-patches at sourceware dot org
- Cc: markus dot t dot metzger at intel dot com, brobecker at adacore dot com, qiyaoltc at gmail dot com
- Date: Mon, 24 Apr 2017 10:35:35 +0200
- Subject: [PATCH v3 3/8] Python: Remove ptid from gdb.Record interface
- Authentication-results: sourceware.org; auth=none
- References: <1493022940-29973-1-git-send-email-tim.wiederhake@intel.com>
As discussed here: https://sourceware.org/ml/gdb-patches/2017-04/msg00166.html
2017-04-24 Tim Wiederhake <tim.wiederhake@intel.com>
gdb/ChangeLog:
* python/py-record.c (recpy_ptid): Remove.
(recpy_record_getset): Remove recpy_ptid.
gdb/doc/ChangeLog:
* python.texi (Recording in Python): Remove Record.ptid defvar.
gdb/testsuite/ChangeLog:
* gdb.python/py-record-btrace.exp: Remove Record.ptid test.
---
gdb/doc/python.texi | 7 -------
gdb/python/py-record.c | 11 -----------
gdb/testsuite/gdb.python/py-record-btrace.exp | 1 -
3 files changed, 19 deletions(-)
diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
index ce5810e..8c246a4 100644
--- a/gdb/doc/python.texi
+++ b/gdb/doc/python.texi
@@ -3110,13 +3110,6 @@ currently active. All record objects become invalid after this call.
A @code{gdb.Record} object has the following attributes:
-@defvar Record.ptid
-ID of the thread associated with this object as a tuple of three integers. The
-first is the Process ID (PID); the second is the Lightweight Process ID (LWPID),
-and the third is the Thread ID (TID). Either the LWPID or TID may be 0, which
-indicates that the operating system does not use that identifier.
-@end defvar
-
@defvar Record.method
A string with the current recording method, e.g.@: @code{full} or
@code{btrace}.
diff --git a/gdb/python/py-record.c b/gdb/python/py-record.c
index 63cd293..05f028c 100644
--- a/gdb/python/py-record.c
+++ b/gdb/python/py-record.c
@@ -29,16 +29,6 @@ static PyTypeObject recpy_record_type = {
PyVarObject_HEAD_INIT (NULL, 0)
};
-/* Implementation of record.ptid. */
-
-static PyObject *
-recpy_ptid (PyObject *self, void* closure)
-{
- const recpy_record_object * const obj = (recpy_record_object *) self;
-
- return gdbpy_create_ptid_object (obj->ptid);
-}
-
/* Implementation of record.method. */
static PyObject *
@@ -161,7 +151,6 @@ Rewind to given location."},
/* Record member list. */
static gdb_PyGetSetDef recpy_record_getset[] = {
- { "ptid", recpy_ptid, NULL, "Current thread.", NULL },
{ "method", recpy_method, NULL, "Current recording method.", NULL },
{ "format", recpy_format, NULL, "Current recording format.", NULL },
{ "replay_position", recpy_replay_position, NULL, "Current replay position.",
diff --git a/gdb/testsuite/gdb.python/py-record-btrace.exp b/gdb/testsuite/gdb.python/py-record-btrace.exp
index 7752cac..ecc8bdf 100644
--- a/gdb/testsuite/gdb.python/py-record-btrace.exp
+++ b/gdb/testsuite/gdb.python/py-record-btrace.exp
@@ -59,7 +59,6 @@ with_test_prefix "preopened record btrace" {
with_test_prefix "prepare record" {
gdb_test_no_output "python r = gdb.start_recording(\"btrace\")"
- gdb_test "python print(len(r.ptid))" "3"
gdb_test "python print(r.method)" "btrace"
gdb_test "python print(r.format)" "pt|bts"
gdb_test "stepi 100" ".*"
--
2.7.4