This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Use containing function when reporting breakpoint location.
- From: Keith Seitz <keiths at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 21 Mar 2017 11:24:24 -0700
- Subject: Re: [PATCH] Use containing function when reporting breakpoint location.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=keiths at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 3850681244
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3850681244
- References: <1489179553-4273-1-git-send-email-keiths@redhat.com> <20170320182241.GA16399@host1.jankratochvil.net>
On 03/20/2017 11:22 AM, Jan Kratochvil wrote:
> The goal is to display "main" in the first case and "f" in the second case.
Bah. Good catch.
> I think this would need to store more information into bp_location to know how
> its CORE_ADDR address has been found.
I considered that, but then decided that was more invasive than I thought it should be. Alas, right now, I don't see another way forward. I'll play with this idea more.
> In my attached patch-idea (not compilable) from 2015-06 (RHBZ 1228549#c5)
> I chose more a quick-hack to reuse 'addr_string', parse it and select only its
> SALs that match by its PC the bp_location being processed/displayed.
I have a patch based on that idea, but I'm a little afraid to introduce that. While skip_inline_frames is known to be an expensive operation, I fear that parsing SaLs in there might kill performance.
Like the bug in $SUBJECT, I have not been able to divine an alternate solution.
As far as this bug is concerned, this patch should be considered rejected/withdrawn.
Thank you, Jan!
Keith