This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Introduce and use disassembly_flags

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Luis Machado <lgustavo at codesourcery dot com>
Cc: gdb-patches at sourceware dot org
Date: Mon, 20 Feb 2017 15:37:24 -0500
Subject: Re: [PATCH] Introduce and use disassembly_flags
Authentication-results: sourceware.org; auth=none
References: <20170211031207.4682-1-simon.marchi@polymtl.ca> <e6bf8ab2-df83-5db2-4f8b-6a07ed09655a@codesourcery.com> <5030fe47c2855e56139d7629d2e6e370@polymtl.ca> <aa362d16-315f-794a-abb3-2ad9e19b2cc4@codesourcery.com>

On 2017-02-20 15:22, Luis Machado wrote:

On 02/18/2017 01:23 PM, Simon Marchi wrote:

On 2017-02-13 15:02, Luis Machado wrote:

Also, should we consider converting DISASSEMBLY_SOURCE_DEPRECATED or
should we let it go? It was introduced in 2015.


What do you mean by "converting"?


Since it is deprecated, do we need to convert/carry it over to the
enum definitions? If not, it could be dropped.

I haven't looked much into this, so i'm not sure if we're still
considering it acceptable to use this deprecated flag.

This flag corresponds to the /m modifier of the disas command, whichitself has been deprecated in 7.11. As long as we don't remove themodifier, we can't remove the flag.


Simon

Follow-Ups:
- Re: [PATCH] Introduce and use disassembly_flags
  - From: Luis Machado

References:
- [PATCH] Introduce and use disassembly_flags
  - From: Simon Marchi
- Re: [PATCH] Introduce and use disassembly_flags
  - From: Luis Machado
- Re: [PATCH] Introduce and use disassembly_flags
  - From: Simon Marchi
- Re: [PATCH] Introduce and use disassembly_flags
  - From: Luis Machado

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]