This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 8/8] DWARF-5: DW_FORM_data16

On Fri, 17 Feb 2017 13:09:42 +0100, Pedro Alves wrote:
> On 02/12/2017 08:23 PM, Jan Kratochvil wrote:
> 
> > @@ -20250,6 +20261,10 @@ dump_die_shallow (struct ui_file *f, int indent, struct die_info *die)
> >  	  fprintf_unfiltered (f, "expression: size %s",
> >  			      pulongest (DW_BLOCK (&die->attrs[i])->size));
> >  	  break;
> > +	case DW_FORM_data16:
> > +	  /* FIXME: Print the contents.  */
> > +	  fprintf_unfiltered (f, "constant of 16 bytes");
> 
> Should we fix that FIXME?

I think even the code above "expression: size %s" should print the contents
which it does not and it has no FIXME there.

So I have just removed the FIXME.


Jan
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]