This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] [BZ 21005] Add support for Intel 64 rdrand and rdseed record/replay
- From: Pedro Alves <palves at redhat dot com>
- To: Luis Machado <lgustavo at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Wed, 1 Feb 2017 11:11:12 +0000
- Subject: Re: [PATCH 2/2] [BZ 21005] Add support for Intel 64 rdrand and rdseed record/replay
- Authentication-results: sourceware.org; auth=none
- References: <1485451129-16439-1-git-send-email-lgustavo@codesourcery.com> <1485451129-16439-2-git-send-email-lgustavo@codesourcery.com>
On 01/26/2017 05:18 PM, Luis Machado wrote:
> The following patch addresses BZ 21005, which is gdb failing to
> recognize an rdrand instruction.
Suggest saying "this patch". "following" won't make sense
when this sentence is part of the git log history.
> [....] I thought we
> had arch-specific tests in testsuite/, but it looks like we don't exercise
> every little instruction with record/replay, so no testcase. Let me know
> if one is required.
This remark looks out of date?
>
> OK?
Please remember to remove this, as it doesn't make sense to have
it in a commit log.
>
> gdb/ChangeLog
>
> 2017-01-26 Luis Machado <lgustavo@codesourcery.com>
>
> * NEWS: Mention support for record/replay of Intel 64 rdrand and
> rdseed instructions.
> i386-tdep.c (i386_process_record): Handle Intel 64 rdrand and rseed.
OK.
Thanks,
Pedro Alves