This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 5/5] Eliminate make_cleanup_ui_file_delete / make ui_file a class hierarchy
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 1 Feb 2017 00:31:39 +0000
- Subject: Re: [PATCH v3 5/5] Eliminate make_cleanup_ui_file_delete / make ui_file a class hierarchy
- Authentication-results: sourceware.org; auth=none
- References: <1484617147-2506-1-git-send-email-palves@redhat.com> <1484617147-2506-6-git-send-email-palves@redhat.com> <5533317a1fdb2e5f36e64731aef84993@polymtl.ca> <4a6cce94-1533-36e9-6015-330e2e014a98@redhat.com> <e24adda8f1a1bc1f50e46fa68219f5c3@polymtl.ca> <558e1e55-23eb-716e-8117-c18d7bded7b8@redhat.com> <79c06dbccef0c33309d208316be207f4@polymtl.ca> <8bf8c6d9-9bbb-be9b-ee5e-99c2c3fa5b8e@redhat.com> <b5c3db20-40b6-9dae-293c-b3fa718a9332@redhat.com> <f7dcd328-3eb4-5e79-93cb-b36f527d3159@redhat.com>
On 01/25/2017 07:47 PM, Pedro Alves wrote:
> On 01/25/2017 07:31 PM, Pedro Alves wrote:
>
>> Here's the diff to the incoming v3. I think this addresses all
>> your comments. The only other change is that I realized that
>> ui_file should be abstract, so that people don't try to allocate
>> one to build a "/dev/null" stream. I've checked the AIX build
>> on gcc119. I'll send v3 shortly.
>
> Here it is. I've pushed it to users/palves/ui_file_v3 too,
> along with the (not posted) "move tee down" follow up patch
> I mentioned.
Today I rebased this on master, and that had conflicts with the
gdb_disassembler wrapper series. Getting rid of the ui_file_rewind
calls in disasm.c required redoing a part of the gdb_disassembler
changes to disasm.c. I think the result looks even better in the end.
I've pushed in the small precursor patches to master, and posted
a v4. Let me know what you think of it.
Thanks,
Pedro Alves