This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 3/5] Rename target descriptions to reflect actual content of description.
- From: Pedro Alves <palves at redhat dot com>
- To: "Sturm, Michael" <michael dot sturm at intel dot com>, mark dot kettenis at xs4all dot nl, eliz at gnu dot org
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 26 Jan 2017 16:17:31 +0000
- Subject: Re: [PATCH v3 3/5] Rename target descriptions to reflect actual content of description.
- Authentication-results: sourceware.org; auth=none
- References: <1481021894-29471-1-git-send-email-michael.sturm@intel.com> <1481021894-29471-4-git-send-email-michael.sturm@intel.com> <aee6eb17-e617-23bc-219a-b2333915c195@redhat.com> <588A1BE9.10408@intel.com>
On 01/26/2017 03:55 PM, Sturm, Michael wrote:
> Hello Pedro,
>
> thank you for pointing this out - this change is not required. I'll
> revert that part for the next version. How about the remainder of the
> patch?
The rest LGTM.
I've suggested before to add a i386/ prefix like you were doing,
in context of a desire to sort that whole list alphabetically
(adding the prefix avoids the 32-bit and 64-bit variants
getting separated). But that should be a separate patch with
its own rationale.
Thanks,
Pedro Alves