This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3] Fix inferior memory reading in GDBServer for arm/aarch32
- From: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: Antoine Tremblay <antoine dot tremblay at ericsson dot com>, <qiyaoltc at gmail dot co>, <gdb-patches at sourceware dot org>
- Date: Mon, 9 Jan 2017 12:40:56 -0500
- Subject: Re: [PATCH v3] Fix inferior memory reading in GDBServer for arm/aarch32
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=antoine dot tremblay at ericsson dot com;
- References: <20161209122339.GG13661@E107787-LIN> <20161209124625.31861-1-antoine.tremblay@ericsson.com> <20170109173056.GB9518@E107787-LIN>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Yao Qi writes:
> On 16-12-09 07:46:25, Antoine Tremblay wrote:
>>
>> This situation is tested with non-stop-fair-events.exp.
>>
>> In other words, single-step breakpoints are installed in proceed_one_lwp
>> for each thread. GDBserver proceeds two threads for resume_step, as
>> requested by GDB, and the thread proceeded later may see the single-step
>> breakpoints installed for the thread proceeded just now.
>>
>> Tested on gdbserver-native/-m{thumb,arm} no regressions.
>
> I assume this patch fixes fails in non-stop-fair-events.exp.
No, it helps but fails are still present, to fix things you need
https://sourceware.org/ml/gdb-patches/2016-11/msg00939.html
and
https://sourceware.org/ml/gdb-patches/2016-11/msg00940.html
If you can take a look at those too it would be nice ?
>
>>
>> gdb/gdbserver/ChangeLog:
>>
>> * linux-aarch32-low.c (arm_breakpoint_kind_from_pc): Use
>> target_read_memory.
>> * linux-arm-low.c (get_next_pcs_read_memory_unsigned_integer): Likewise.
>> (get_next_pcs_syscall_next_pc): Likewise.
>
> Patch is good to me.
Patch is pushed in.