This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 7/8] Fix test names starting with uppercase using multi-line gdb_test_multiple


On 11/30/2016 09:05 PM, Luis Machado wrote:

> gdb_test_no_output then? It doesn't check for any output other than the
> prompt.

'-re "$gdb_prompt $"' implicitly matches whatever might come before
the prompt too, but yeah, that'd be better even, assuming the command
doesn't output anything, which is probably true.

OK with that change.

> 
>> ?
>>
>> I'd end up fixing two extra things:
>>
>>  - note the typo in the pass case: "unwiNN"
>>  - odd "(timeout)" print position.  timeout handling it not necessary
>>    at all with gdb_test_multiple, even.
> 
> I see more occurrences of expecting timeouts where they're not needed.
> I'll fix in a follow-on patch.

Thanks much!

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]