This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 7/8] Use unique_xmalloc_ptr in execute_gdb_command


>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:

Tom> This replaces a cleanup in execute_gdb_command with an instance of
Tom> unique_xmalloc_ptr.  std::string was not used because execute_command
Tom> and execute_command_to_string don't accept a "const char *" (in fact
Tom> the reason for copying the string at all).

To my surprise, this patch is broken.
I must not have re-run the python tests locally after writing it :(

The problem is that prevent_dont_repeat returns a cleanup, which is then
left dangling after this patch.

I'm looking into a fix.  Meanwhile I think the rest of the series can
still be considered.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]