This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/2] gdb: Simplify variable set hooks

From: Pedro Alves <palves at redhat dot com>
To: Andrew Burgess <andrew dot burgess at embecosm dot com>, gdb-patches at sourceware dot org
Date: Thu, 24 Nov 2016 23:57:36 +0000
Subject: Re: [PATCH 2/2] gdb: Simplify variable set hooks
Authentication-results: sourceware.org; auth=none
References: <1478888325-32039-1-git-send-email-andrew.burgess@embecosm.com> <1478888325-32039-3-git-send-email-andrew.burgess@embecosm.com>

On 11/11/2016 06:18 PM, Andrew Burgess wrote:
> Now the the variable set-hook mechanism supports automatic rollback of
> the variable value if the set-hook throws an error, simplify existing
> cases where we manually performed roll-back within the set-hook.

Looks good, if we assume we end up agreeing on the previous patch.

Off hand, I recall "set non-stop" and "maint set target-async" as
two other commands that could be simplified.

Thanks,
Pedro Alves

References:
- [PATCH 0/2] Auto roll back on error while changing a setting
  - From: Andrew Burgess
- [PATCH 2/2] gdb: Simplify variable set hooks
  - From: Andrew Burgess

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]