This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 13/22] Replace hand-made linked list of ui_out_hdr by vector and iterator

From: Pedro Alves <palves at redhat dot com>
To: Simon Marchi <simon dot marchi at polymtl dot ca>, gdb-patches at sourceware dot org
Date: Thu, 24 Nov 2016 18:41:31 +0000
Subject: Re: [PATCH 13/22] Replace hand-made linked list of ui_out_hdr by vector and iterator
Authentication-results: sourceware.org; auth=none
References: <20161124152428.24725-1-simon.marchi@polymtl.ca> <20161124152710.25007-13-simon.marchi@polymtl.ca>

On 11/24/2016 03:27 PM, Simon Marchi wrote:
> Instead of keeping pointers to first, last and current ui_out_hdr in
> ui_out_table, we can use an std::vector and an iterator.  Direct random
> access of to vector helps make get_next_header a bit nicer by avoiding
> iterating on all the headers.  append_header_to_list is also a bit
> simpler.

Inserting into a vector invalidates iterators if it causes reallocation.
I think we're good because there's be some call to start_body
or start_row before the iterator is ever dereferenced, right?

Thanks,
Pedro Alves

Follow-Ups:
- Re: [PATCH 13/22] Replace hand-made linked list of ui_out_hdr by vector and iterator
  - From: Simon Marchi

References:
- [PATCH 00/22] Convert ui-out subsystem to C++
  - From: Simon Marchi
- [PATCH 13/22] Replace hand-made linked list of ui_out_hdr by vector and iterator
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]