Re: [PATCH 02/23] Fix spelling mistakes in comments in C source files (gdb)

[Pedro Alves <palves at redhat dot com>]

On 11/21/2016 03:43 PM, Yao Qi wrote:

> Ambrogino doesn't have FSF copyright assignment, but I don't think
> it is required in this case, because IMO, this patch is not a
> "legally significant change"
> https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html
> and it can be regarded as "tiny change", although the patch is
> not tiny, and the url above doesn't explicitly mention "fixing typo"
> is not legally significant change.

I agree.  IANAL and all that, but IMHO there's no copyrightable
content here.  Two patches independently written from scratch to
fix these typos would be indistinguishable.  I.e., it's a mechanical
change.  I think we're OK.

Please find a couple comments below.

> --- a/gdb/cli/cli-decode.c
> +++ b/gdb/cli/cli-decode.c
> @@ -956,7 +956,7 @@ apropos_cmd (struct ui_file *stream,
>        command that requires subcommands.  Also called by saying just
>        "help".)
>  
> -   I am going to split this into two seperate comamnds, help_cmd and
> +   I am going to split this into two separate comamnds, help_cmd and

"commands" too, while at it.

>     help_list.  */
>  
>  void

> --- a/gdb/arch-utils.c
> +++ b/gdb/arch-utils.c
> @@ -98,7 +98,7 @@ legacy_register_sim_regno (struct gdbarch *gdbarch, int regnum)
>    gdb_assert (regnum >= 0 && regnum < gdbarch_num_regs (gdbarch));
>    /* NOTE: cagney/2002-05-13: The old code did it this way and it is
>       suspected that some GDB/SIM combinations may rely on this
> -     behavour.  The default should be one2one_register_sim_regno
> +     behaviour.  The default should be one2one_register_sim_regno

We use American English spelling, so should be "behavior", I believe.

>       (below).  */
>    if (gdbarch_register_name (gdbarch, regnum) != NULL
>        && gdbarch_register_name (gdbarch, regnum)[0] != '\0')