This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 03/20] Fix spelling mistakes in comments in makefiles
On 2016-11-20 10:06, Ambrogino Modigliani wrote:
gas/ChangeLog:
* gas/Makefile.am: Fix spelling in comments.
* gas/Makefile.in: Fix spelling in comments.
This is almost nit-picking, since the end result is the same, but I'll
say it just to be sure you know about it. This particular "Makefile.in"
is generated from "Makefile.am" using automake-1.11 (as seen in the
header of Makefile.in). Just like with the "configure" scripts, you
should not edit "Makefile.in" directly. You first edit "Makefile.am"
and run automake-1.11 to generate "Makefile.in" (again, some
distributions still package automake 1.11). Then, your ChangeLog entry
can look like:
gas/ChangeLog:
* Makefile.am: Fix spelling in comments.
* Makefile.in: Re-generate.
When there's a "Makefile.in" without a "Makefile.am", it means that this
one is written by hand, so it's okay to edit it directly.
Another point, which I think applies to all of your patches, is that
your ChangeLog entries should be relative to the location of the
ChangeLog they belong in. For example, since this entry goes in
"gas/ChangeLog", the entry referring to "gas/Makefile.am" should not be:
* gas/Makefile.am: Fix spelling in comments.
but:
* Makefile.am: Fix spelling in comments.
Thanks,
Simon