This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 06/11] Change type of encoding argument to gdbpy_extract_lazy_string
On 11/12/2016 09:28 PM, Tom Tromey wrote:
> This changes gdbpy_extract_lazy_string's "encoding" argument to be a
> unique_xmalloc_ptr. I chose this rather than std::string because it
> can sometimes be NULL.
[OOC, the other day I backported GCC trunk's C++17's std::optional
to C++11, just to see how it'd look. Surprisingly, it compiles
almost OOTB, with no loss in functionality. Mostly, it requires
backporting a few trait types that are missing in C++11. Anyway, I
wouldn't really propose adding that unless there was a great
advantage.]
>
> 2016-11-12 Tom Tromey <tom@tromey.com>
>
> * python/py-prettyprint.c (print_string_repr, print_children):
> Update.
> * python/py-lazy-string.c (gdbpy_extract_lazy_string): Change type
> of "encoding".
> * varobj.c (varobj_value_get_print_value): Update.
> * python/python-internal.h (gdbpy_extract_lazy_string): Update.
LGTM.
Thanks,
Pedro Alves