This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 5/5] Stash frame id of current frame before stashing frame id for previous frame
- From: Pedro Alves <palves at redhat dot com>
- To: Kevin Buettner <kevin at buettner dot to>, gdb-patches at sourceware dot org
- Date: Wed, 9 Nov 2016 14:48:46 +0000
- Subject: Re: [PATCH v2 5/5] Stash frame id of current frame before stashing frame id for previous frame
- Authentication-results: sourceware.org; auth=none
- References: <20161102151111.2462c806@pinnacle.lan> <20161102152601.6e79f698@pinnacle.lan>
On 11/02/2016 10:26 PM, Kevin Buettner wrote:
> I will first note that the frame id for frame has not been computed yet. (This
> was verified by placing a breakpoint on compute_frame_id().)
>
> The call to get_prev_frame() causes the the frame id to (eventually) be
> computed for the previous frame. Here's a backtrace showing how we
> get there:
>
> at gdb/frame.c:496
> at gdb/frame.c:1871
> at gdb/frame.c:2045
> at gdb/frame.c:2061
> at gdb/frame.c:2303
> at gdb/python/py-frame.c:381
Function names would make that backtrace soooo much easier to read. :-)
> gdb/ChangeLog:
>
> * frame.c (get_prev_frame): Stash frame id for current frame
> prior to computing frame id for previous frame.
I'm fine with this solution. LGTM.
Thanks,
Pedro Alves