This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH V2 5/5] Support tracepoints for ARM linux in GDBServer
- From: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: Antoine Tremblay <antoine dot tremblay at ericsson dot com>, <gdb-patches at sourceware dot org>
- Date: Thu, 3 Nov 2016 14:12:22 -0400
- Subject: Re: [PATCH V2 5/5] Support tracepoints for ARM linux in GDBServer
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=antoine dot tremblay at ericsson dot com;
- References: <20161103143300.24934-1-antoine.tremblay@ericsson.com> <20161103143300.24934-6-antoine.tremblay@ericsson.com> <838tt0moyd.fsf@gnu.org>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Eli Zaretskii writes:
>> From: Antoine Tremblay <antoine.tremblay@ericsson.com>
>> CC: Antoine Tremblay <antoine.tremblay@ericsson.com>
>> Date: Thu, 3 Nov 2016 10:33:00 -0400
>>
>> diff --git a/gdb/NEWS b/gdb/NEWS
>> index a6b1282..233f11e 100644
>> --- a/gdb/NEWS
>> +++ b/gdb/NEWS
>> @@ -3,6 +3,8 @@
>>
>> *** Changes since GDB 7.12
>>
>> +* Support for tracepoints on arm-linux was added in GDBServer.
>> +
>> * Building GDB and GDBserver now requires a C++11 compiler.
>>
>> For example, GCC 4.8 or later.
>
> This part is OK.
>
>> +encodings as described below. If a @samp{K} is present, it
>> +indicates a target specific breakpoint kind. The kind can be the
>
> Please use @var{kind} here, in reference to the packet parameter.
>
Ooops fixed.
>> +length of the breakpoint. E.g., the arm and mips can insert either a
>> +2 or 4 byte breakpoint or have additional meaning see
>> +@ref{Architecture-Specific Protocol Details}. If the trailing @samp{-}
>> +is present, further @samp{QTDP} packets will follow to specify this
>> +tracepoint's actions.
>
> This paragraph needs to use 2 spaces between sentences, not one.
>
Right, fixed.
> The patch for the manual is OK with these gotchas fixed.
>
> Thanks.