This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, RFC] Add support for choosing disassembler cpu in GDB for POWER.
- From: Peter Bergner <bergner at vnet dot ibm dot com>
- To: Pedro Alves <palves at redhat dot com>, Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: Alan Modra <amodra at gmail dot com>, gdb-patches at sourceware dot org, binutils <binutils at sourceware dot org>
- Date: Thu, 3 Nov 2016 10:02:19 -0500
- Subject: Re: [PATCH, RFC] Add support for choosing disassembler cpu in GDB for POWER.
- Authentication-results: sourceware.org; auth=none
- References: <20161012082525.3250910FDC3@oc8523832656.ibm.com> <ba2c8e0f-eb8e-d0b9-313c-022c61ebb9ab@vnet.ibm.com> <88940498-822b-b192-b983-d8571a81ad87@redhat.com> <c4178472-1654-5700-0ba7-2d54eff74cf0@vnet.ibm.com> <2c62687d-f013-5af8-96ae-d7f56d28c218@redhat.com> <4f8959a7-33b9-385c-3c63-2d5b26286579@vnet.ibm.com> <3b814d5e-f716-f1c7-1530-684901b28e30@redhat.com> <88312c99-f1bb-c3d9-8e65-8ab64f086f42@vnet.ibm.com> <8733fac4-9e5d-43de-75a6-0f191c4000e7@redhat.com>
On 11/3/16 6:01 AM, Pedro Alves wrote:
On 10/28/2016 03:53 PM, Peter Bergner wrote:
BTW, I'm also not sure about saying "default" in "show disassembler-options".
I don't think "set disassembler-options default" would work?
Do we still need that given the option is no longer described in
terms of cpus?
Uli and I discussed this here:
https://sourceware.org/ml/gdb-patches/2016-10/msg00184.html
https://sourceware.org/ml/gdb-patches/2016-10/msg00188.html
Uli didn't like (at least the way the code was written in the earlier
patch) how I was trying to initialize the disassembler_options
to a default. He thought that just leaving disassembler_options NULL
and letting the arch choose its default was best. That's when I added
the code to emit "default" whenever disassembler_options is NULL.
Related, "set disassembler-options" should work to clear options.
I couldn't tell whether it works from a quick skim over your
latest patch.
As part of my last patch:
https://sourceware.org/ml/gdb-patches/2016-11/msg00023.html
...is said:
> Secondly, I wanted a way for the user to go back to the default
> (ie, NULL) disassembler option. I could only do that first I
> removed white space. I added the comma cleanup since it was
> easy.
So yes, we can go back to the NULL default.
Peter