This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 2/2] Make some dwarf_expr_context methods pure virtual
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: palves at redhat dot com (Pedro Alves)
- Cc: tom at tromey dot com (Tom Tromey), gdb-patches at sourceware dot org
- Date: Mon, 24 Oct 2016 14:28:02 +0200 (CEST)
- Subject: Re: [RFA 2/2] Make some dwarf_expr_context methods pure virtual
- Authentication-results: sourceware.org; auth=none
Pedro Alves wrote:
> On 10/20/2016 10:51 PM, Tom Tromey wrote:
> > This patch changes some dwarf_expr_context to be pure virtual, as
> > mentioned during the discussion of an earlier patch in this series.
> >
> > 2016-10-20 Tom Tromey <tom@tromey.com>
> >
> > * dwarf2expr.h (class dwarf_expr_context)
> > <get_frame_base, get_frame_cfa, get_tls_address, dwarf_call,
> > push_dwarf_block_entry_value, get_addr_index, get_object_address>:
> > Now pure virtual.
> > * dwarf2-frame.c (class dwarf_expr_executor)
> > <get_frame_base, get_frame_cfa, get_tls_address, dwarf_call,
> > push_dwarf_block_entry_value, get_addr_index, get_object_address>:
> > New methods.
> > <invalid>: New method.
>
> Nice, thanks. LGTM.
This seems to have broken my SPU daily build (running on RHEL 5 with a
GCC 4.1 system compiler):
gdb/dwarf2expr.h:69: warning: 'struct dwarf_expr_context' has virtual functions but non-virtual destructor
Is this a C++ version issue?
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com