This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] Remove unused parameter in solib_add and update_solib_list
- From: Simon Marchi <simon dot marchi at polymtl dot ca>
- To: Marc-Andre Laperle <marc-andre dot laperle at ericsson dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 20 Oct 2016 00:20:29 -0400
- Subject: Re: [PATCH 1/3] Remove unused parameter in solib_add and update_solib_list
- Authentication-results: sourceware.org; auth=none
- References: <1473712054-30417-1-git-send-email-marc-andre.laperle@ericsson.com>
On 2016-09-12 16:27, Marc-Andre Laperle wrote:
The target parameter in both solib_add and update_solib_list
functions is not used anymore and as not been used for a while. This
change removes the parameter to clean up the code a little bit.
gdb/ChangeLog:
* infcmd.c (post_create_inferior): Remove unused argument in
call to solib_add.
* remote.c (remote_start_remote): Likewise.
* solib-frv.c (frv_fetch_objfile_link_map): Likewise.
* solib-svr4.c: (svr4_fetch_objfile_link_map): Likewise.
(enable_break): Likewise.
* solib.c (update_solib_list): Remove unused target argument
and its documentation.
(solib_add): Remove unused target argument. Remove unused
argument in call to update_solib_list.
(info_sharedlibrary_command): Remove unused argument in call
to update_solib_list.
(sharedlibrary_command): Remove unused argument in call to
solib_add.
(handle_solib_event): Likewise.
(reload_shared_libraries): Likewise.
* solib.h (solib_add): Remove unused target argument.
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
This patch looks good to me.