This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA v2 16/17] Convert dwarf_expr_context_funcs to methods

>>>>> "Pedro" == Pedro Alves <> writes:

>> -	  result = (this->funcs->get_addr_index) (this->baton, uoffset);
>> +	  result = (this->get_addr_index) (uoffset);

Pedro> Should we remove the parens throughout?

I made this change.

>> +  /* Push on DWARF stack an entry evaluated for DW_TAG_GNU_call_site's
>> +     parameter matching KIND and KIND_U at the caller of specified BATON.
>> + If DEREF_SIZE is not -1 then use DW_AT_GNU_call_site_data_value
>> instead of
>> +     DW_AT_GNU_call_site_value.  */
>> + virtual void push_dwarf_reg_entry_value (enum
>> call_site_parameter_kind kind,
>> +					   union call_site_parameter_u kind_u,
>> +					   int deref_size)
>> +  {
>> +    internal_error (__FILE__, __LINE__,
>> +		    _("Support for DW_OP_GNU_entry_value is unimplemented"));

Pedro> Hmm, I think you may have missed my comments to this patch in v1.

All I saw was the comment about possibly reducing churn:

... but the way that was worded, I thought it didn't need any changes.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]