This is the mail archive of the
mailing list for the GDB project.
Re: [RFA 06/22] Introduce scoped_minimal_symbol_reader
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 11 Oct 2016 00:25:59 +0100
- Subject: Re: [RFA 06/22] Introduce scoped_minimal_symbol_reader
- Authentication-results: sourceware.org; auth=none
- References: <firstname.lastname@example.org> <email@example.com> <firstname.lastname@example.org> <email@example.com>
On 10/11/2016 12:06 AM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <firstname.lastname@example.org> writes:
> Pedro> GCC eschews using // comments, to avoid ending up with a mixbag
> Pedro> of styles. Maybe we should follow suit?
> I don't remember - did you want me to change this or not?
> I prefer "//" comments but it's up to you.
I'd prefer to change it for the sake of consistency. A single comment
in a different style in between other comments stands out as odd to me.
For tail-end single-line comments, like
} // namespace gdb
it doesn't look that odd to me. AFAICS, these are the cases
where gcc uses // too, for the most part.