This is the mail archive of the
mailing list for the GDB project.
Re: [RFA 1/3] Fix "fall through" comments
- From: Tom Tromey <tom at tromey dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: Tom Tromey <tom at tromey dot com>, "gdb-patches\@sourceware.org" <gdb-patches at sourceware dot org>
- Date: Tue, 27 Sep 2016 15:10:09 -0600
- Subject: Re: [RFA 1/3] Fix "fall through" comments
- Authentication-results: sourceware.org; auth=none
- References: <email@example.com> <firstname.lastname@example.org> <CAH=s-PNKhnmRVYbhoA4dKBkz-QYyU3_gc_z9da2Z5spAfUTO4Q@mail.gmail.com>
>>>>> "Yao" == Yao Qi <email@example.com> writes:
Yao> clang has -Wimplicit-fallthrough as well, but warnings are suppressed in
Yao> a different way. Do we need to suppress warnings generated by both gcc
Yao> and clang?
On my machine, clang won't build gdb. From memory there was at least
some issue compiling .c files in c++ mode, but I think there were other
problems as well.
If clang support is desired, then yes, the correct approach is to
replace the fall-through comments with a new attribute.