This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Close gdbserver in mi_gdb_exit
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Thu, 22 Sep 2016 15:17:26 +0100
- Subject: Re: [PATCH] Close gdbserver in mi_gdb_exit
- Authentication-results: sourceware.org; auth=none
- References: <1474552922-29654-1-git-send-email-yao.qi@linaro.org>
Hi Yao,
Thanks for fixing this.
On 09/22/2016 03:02 PM, Yao Qi wrote:
> 2016-09-22 Yao Qi <yao.qi@linaro.org>
>
> * lib/gdbserver-support.exp: Rename mi_gdb_exit.
> (gdb_exit): Rename it to ...
> (gdbserver_gdb_exit): ... Close GDBserver.
> (gdb_exit): New proc, call gdbserver_gdb_exit.
> (mi_gdb_exit): Likewise.
Looks good.
> + if { $is_mi } {
> + set monitor_exit "-interpreter-exec console \"monitor exit\"\n"
That "\n" at the end, is it stray or necessary?
> + } else {
> + set monitor_exit "monitor exit"
> + }
> + send_gdb "$monitor_exit\n";
I ask because this here already includes a \n.
Thanks,
Pedro Alves