This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH 0/6] S390: Watchpoint enhancements and hardware breakpoints
- From: Pedro Alves <palves at redhat dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>, gdb-patches at sourceware dot org
- Date: Fri, 16 Sep 2016 16:43:48 +0100
- Subject: Re: [PATCH 0/6] S390: Watchpoint enhancements and hardware breakpoints
- Authentication-results: sourceware.org; auth=none
- References: <20160916124323.AE052FE999@oc8523832656.ibm.com>
On 09/16/2016 01:43 PM, Ulrich Weigand wrote:
> Pedro Alves wrote:
>> I'm curious on the need to disable hw breakpoints when single-stepping.
> This is more of a hardware restriction than a GDB issue. The problem is
> that s390 hardware doesn't really have a separate hardware single-step
> feature; to implement ptrace single-stepping, the kernel uses the s390
> hardware breakpoint feature (in effect, enabling hardware breakpoints
> on the full address space, which will hit on the next instruction that
> is executed).
> This use of the feature by kernel single-stepping can conflict with
> explicit use of the same feature by GDB; that's why it is better to
> not attempt such explicit use while at the same time also requesting
> kernel single-stepping.
I see. Thanks for the clarification.
A comment to the effect in the code would be nice. Maybe it's
there and I missed it.
I have no further comments on the series. LGTM.