This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Avoid -Wduplicated-cond warnings in gdb/python
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 15 Sep 2016 16:20:58 +0100
- Subject: Re: [RFA] Avoid -Wduplicated-cond warnings in gdb/python
- Authentication-results: sourceware.org; auth=none
- References: <1469130496-15433-1-git-send-email-tom@tromey.com> <87bmzzptfl.fsf@tromey.com>
On 09/07/2016 05:26 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>
> Tom> I tried building gdb with -Wduplicated-cond. This patch fixes the
> Tom> simpler issue that was found.
>
> [...]
>
> Tom> 2016-07-21 Tom Tromey <tom@tromey.com>
>
> Tom> * python/py-value.c (convert_value_from_python): Make PyInt_Check
> Tom> conditional on Python 2.
> Tom> * python/py-arch.c (archpy_disassemble): Make PyInt_Check
> Tom> conditional on Python 2.
>
> Ping.
> I realized today that this was never reviewed.
This is OK. I'd be totally fine with you self approving
this...
Thanks,
Pedro Alves