This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH master+7.12 v2 1/3] Introduce cleanup to restore current_uiout

On 09/14/2016 07:18 PM, Simon Marchi wrote:
> On 16-09-14 02:10 PM, Tom Tromey wrote:
>>>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
>>
>> Simon> -  old_chain = make_cleanup (restore_current_uiout_cleanup, current_uiout);
>> Simon> +  old_chain = make_cleanup_restore_current_uiout ();
>>
>> There's also already make_cleanup_restore_ui_out.
>> You could just use "make_cleanup_restore_ui_out (&current_uiout)" instead.
>>
>> Tom
> 
> Ah good point, I'll probably do that.

FWIW, I like the newer spelling better since we'll always be
restoring current_uiout, but it's not a big deal at all.
(similarly to https://sourceware.org/ml/gdb-patches/2016-09/msg00060.html)

Thanks,
Pedro Alves
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]