This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix for gdb.server/non-existing-program.exp test case

On Tue, 2016-09-13 at 17:37 +0200, Ulrich Weigand wrote:
> Carl Love wrote:
> > I fixed up the comment per your suggestion.  Not sure what happened with
> > the formatting. See if this looks better.
> > +  /* The last_status.kind was set by the call to ptrace(PTRACE_TRACEME, ...).
> > +     The function linux_wait() has also been called.  At this point, the
> > +     target process, if it exits, is stopped.  Do not call the function
> > +     target_post_create_inferior if the process has already exited, as the
> > +     target implementation of the routine may rely on the process being live.
> > +  */
> Formatting looks OK now, except that the trailing */ should not be on a
> separate line; see other multi-line comments how those should look like.
> However, the comment still mentions ptrace and linux_wait, which is also
> only true on Linux targets.  I'd just leave that off.
> Patch is OK with that change.
> Bye,
> Ulrich

Patch committed. Note, I updated the comment per requested.  Note, I
realized I only did part of the requested update initially and then did
then removed the ptrace () comment.  The patch didn't get updated with
the removal of the ptrace () comment.  I had to do a second commit to
get the ptrace () comment fixed correctly.  Sorry for the screw up.
Here are the two commits.;a=commit;h=1d8cb77dff14d44b1e3b670442438da496f99c6e;a=commit;h=7313bced5b695b71a707c82b6817763046e21bb1

                    Carl Love

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]