This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix for gdb.server/non-existing-program.exp test case

Carl Love wrote:

> 2016-09-06  Carl Love  <>
>             * server.c (start_inferior):  Do not call
>             function target_post_create_inferior () if the
>             inferior process has already exited.

The patch makes sense to me, however there seem to be
some formatting issues (mail client problems?):

> +  /* The last_status.kind was set by the call to
> ptrace(PTRACE_TRACEME, ...).
> +     The function linux_wait() has also been called.  At this point,
> the
> +     target process, if it exits, is stopped.  Depending on the
> architecture,
> +     the function target_post_create_inferior () may make additional
> ptrace ()
> +     calls that will fail if the target has already exited.
> +  */

Please make sure this is properly formatted (and does not exceed
the 80 characters per line limit).

Also, the comment seems a bit too specific; this file is also used
for targets other than Linux that may not use ptrace specifically.
I'd word the comment a bit more generically, along the lines of
"Do not call target_post_create_inferior if the process has already
exited, since the target implementation of that routine may rely on
the process being live."


  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]