This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] Use target_continue{,_no_signal} instead of target_resume
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Thu, 01 Sep 2016 14:57:34 -0400
- Subject: Re: [PATCH 1/2] Use target_continue{,_no_signal} instead of target_resume
- Authentication-results: sourceware.org; auth=none
- References: <1472443911-29056-1-git-send-email-sergiodj@redhat.com> <1472443911-29056-2-git-send-email-sergiodj@redhat.com> <88f0aa5b-35de-4382-0a34-2c0df2ca1546@redhat.com>
On Wednesday, August 31 2016, Pedro Alves wrote:
> On 08/29/2016 05:11 AM, Sergio Durigan Junior wrote:
>
>> diff --git a/gdb/target/target.h b/gdb/target/target.h
>> index 76af732..1bfa1b0 100644
>> --- a/gdb/target/target.h
>> +++ b/gdb/target/target.h
>> @@ -70,4 +70,10 @@ extern void target_stop_and_wait (ptid_t ptid);
>>
>> extern void target_continue_no_signal (ptid_t ptid);
>>
>> +/* Restart a target previously stopped by target_stop_and_wait.
>
> Given you're using this function in other contexts, this sentence
> doesn't sound right. Likewise, the existing comment on top of
> target_continue_no_signal is no longer accurate.
Thanks, fixed and pushed.
049a857091cff98371b5688140832a3cf767153c
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/