Re: [PATCH 1/2] Use target_continue{,_no_signal} instead of target_resume

[Pedro Alves <palves at redhat dot com>]

On 08/29/2016 05:11 AM, Sergio Durigan Junior wrote:

> diff --git a/gdb/target/target.h b/gdb/target/target.h
> index 76af732..1bfa1b0 100644
> --- a/gdb/target/target.h
> +++ b/gdb/target/target.h
> @@ -70,4 +70,10 @@ extern void target_stop_and_wait (ptid_t ptid);
>  
>  extern void target_continue_no_signal (ptid_t ptid);
>  
> +/* Restart a target previously stopped by target_stop_and_wait.

Given you're using this function in other contexts, this sentence
doesn't sound right.  Likewise, the existing comment on top of
target_continue_no_signal is no longer accurate.

Otherwise LGTM.

> +   SIGNAL is delivered to the target.  This function must be provided
> +   by the client.  */
> +
> +extern void target_continue (ptid_t ptid, enum gdb_signal signal);
> +
>  #endif /* TARGET_COMMON_H */
> 

Thanks,
Pedro Alves