This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Allow resetting an empty inferior-tty
On 16-08-24 11:33 AM, Pedro Alves wrote:
>> + if (terminal_name != NULL && strlen (terminal_name) > 0)
>
> Use th idiomatic empty-string check: *terminal_name != '\0'
Done.
>> /* Add the filename of the terminal connected to inferior I/O. */
>> - add_setshow_filename_cmd ("inferior-tty", class_run,
>> - &inferior_io_terminal_scratch, _("\
>> + add_setshow_optional_filename_cmd ("inferior-tty", class_run,
>> + &inferior_io_terminal_scratch, _("\
>> Set terminal for future runs of program being debugged."), _("\
>> Show terminal for future runs of program being debugged."), _("\
>> Usage: set inferior-tty /dev/pts/1"),
>
> Should we update the online help too?
The online help is generated from the doc, which I updated, so it should
be ok, no? Unless you are talking about something else?