Re: warning: Could not load shared library symbols for linux-vdso.so.1.

[Yao Qi <qiyaoltc at gmail dot com>]

On Fri, Aug 19, 2016 at 11:32 AM, Pedro Alves <palves@redhat.com> wrote:
>>
>> They are good to me.  Do you plan to push them to 7.12 branch?
>
> I was working under the assumption you wanted it in 7.12, given
> you set the milestone.  :-)
>

I put this issue there to make sure we don't forget this one.  At that moment,
I didn't expect a big change. :)

>
> However, if you want this on 7.12, then there's another option.  We
> can start with the hacky version that moves the add_vsyscall_page
> call to gdbarch_vsyscall_range, as mentioned in:
>
>> Now, in order to do this, we need to move the add_vsyscall_page
>> call earlier, before svr4_current_dsos is ever called, in order
>> to read the vdso bfd out of memory before we ever first need to
>> filter out the vdso.  The cleanest I could do with the current
>> gdbarch_vsyscall_range-based design was to do the add_vsyscall_page
>> call from within gdbarch_vsyscall_range.  But that looks very ugly
>> to me, for reading symbols from a quite innocent looking gdbarch hook.
>
> and then clean this up with the new linux_so_ops, on master, only.

OK, that is fine.

>
> So below's the "ugly" patch.  It's functionally exactly the same as
> the larger one.  The switch to linux_so_ops was mainly "cosmetic".
>
> Let me know what you prefer.
>

This patch is good to master and 7.12.

-- 
Yao (齐尧)