This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Sync proc_service definition with GLIBC
- From: Pedro Alves <palves at redhat dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, gdb-patches at sourceware dot org
- Date: Thu, 18 Aug 2016 00:13:15 +0100
- Subject: Re: [PATCH] Sync proc_service definition with GLIBC
- Authentication-results: sourceware.org; auth=none
- References: <1471468737-10208-1-git-send-email-adhemerval.zanella@linaro.org>
On 08/17/2016 10:18 PM, Adhemerval Zanella wrote:
> GLIBC BZ#20311 [1] proc_service.h install patch also remove 'const'
> attributes from ps_get_thread_area and comment #15 discuss why to remove
> the const attribute (basically since it a callback with the struct
> ps_prochandle owned by the client it should be able to modify it if
> it the case).
>
> On default build this is not the issue and current g++ does not trigger
> any issue with this mismatch declaration. However, on some bootstrap
> build configuration where gdbserver is build with gcc instead this
> triggers:
>
> error: conflicting types for 'ps_get_thread_area'
>
> This patch fixes it by syncing the declaration with GLIBC.
>
> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=20311
>
> 2016-08-17 Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> * gdb/aarch64-linux-nat.c (ps_get_thread_area): Remove const from
> struct ps_prochandle.
> * gdb/amd64-linux-nat.c (ps_get_thread_area): Likewise.
> * gdb/arm-linux-nat.c (ps_get_thread_area): Likewise.
> * gdb/gdb_proc_service.h (ps_get_thread_area): Likewise.
> * gdb/gdbserver/gdb_proc_service.h (ps_get_thread_area): Likewise.
> * gdb/gdbserver/linux-aarch64-low.c (ps_get_thread_area): Likewise.
> * gdb/gdbserver/linux-arm-low.c (ps_get_thread_area): Likewise.
> * gdb/gdbserver/linux-crisv32-low.c (ps_get_thread_area): Likewise.
> * gdb/gdbserver/linux-m68k-low.c (ps_get_thread_area): Likewise.
> * gdb/gdbserver/linux-mips-low.c (ps_get_thread_area): Likewise.
> * gdb/gdbserver/linux-nios2-low.c (ps_get_thread_area): Likewise.
> * gdb/gdbserver/linux-tic6x-low.c (ps_get_thread_area): Likewise.
> * gdb/gdbserver/linux-x86-low.c (ps_get_thread_area): Likewise.
> * gdb/gdbserver/linux-xtensa-low.c (ps_get_thread_area): Likewise.
> * gdb/i386-linux-nat.c (ps_get_thread_area): Likewise.
> * gdb/m68klinux-nat.c (ps_get_thread_area): Likewise.
> * gdb/mips-linux-nat.c (ps_get_thread_area): Likewise.
> * gdb/nat/aarch64-linux.c (aarch64_ps_get_thread_area): Likewise.
> * gdb/nat/aarch64-linux.h (aarch64_ps_get_thread_area): Likewise.
> * gdb/xtensa-linux-nat.c (ps_get_thread_area): Likewise.
OK, but please move the ChangeLog entries to the correct ChangeLog files,
and make the entry paths be relative to the corresponding ChangeLog file.
gdbserver changes go to gdb/gdbserver/ChangeLog, the rest goes
to gdb/ChangeLog.
Thanks,
Pedro Alves