Re: Program-assigned thread names on Windows

[LRN <lrn1986 at gmail dot com>]

On 10.08.2016 15:15, Pedro Alves wrote:
> On 08/10/2016 08:11 AM, LRN wrote:
>> No one seems to object.
>>
> 
> I was going to apply your patches, so I squashed them all, and
> only after did I notice the problems, so I went ahead and did
> the changes.  I also fixed a couple typos in the commit log.
> 
> Could you give this updated patch a try?  I build-tested it using
> a cross compiler, but haven't tried it out on Windows.


Curses! I've been reading your message like a set of last-minute nitpicks,
fixing things in my patch as i went along. I got to the named_thread->name
and overriding "thread name" part, then went ahead and fixed that too. Then
got to the end of the email and found out that you've done that already!
:-\ Good job, me...

Anyway, i've applied your patch. gdb compiles. threadname-setting
functionality works as expected: "thread name X" has precedence, "thread
name" (with no name) allows app-assigned name (if any) to be shown once again.

I've also applied my version of the patch. gdb also compiles.
threadname-setting functionality also works as expected. Therefore i'm
attaching my version, in case you find it useful.

I've only tested 32-bit version of gdb (hoping that none of the recent
changes touch anything architecture-dependent).

-- 
O< ascii ribbon - stop html email! - www.asciiribbon.org

Attachment: 0001-Support-settings-thread-name-MS-Windows.patch
Description: Text document

Attachment: 0x6759BA74.asc
Description: application/pgp-keys

Attachment: signature.asc
Description: OpenPGP digital signature