This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[pushed] Quiet ARI gettext checks (Re: New ARI warning Wed Aug 10 01:56:29 UTC 2016)
- From: Pedro Alves <palves at redhat dot com>
- To: GDB Administrator <gdbadmin at sourceware dot org>, gdb-patches at sourceware dot org
- Date: Wed, 10 Aug 2016 16:09:03 +0100
- Subject: [pushed] Quiet ARI gettext checks (Re: New ARI warning Wed Aug 10 01:56:29 UTC 2016)
- Authentication-results: sourceware.org; auth=none
- References: <20160810015629.GA47929@sourceware.org>
On 08/10/2016 02:56 AM, GDB Administrator wrote:
> 89a90,93
>> gdb/common/signals-state-save-restore.c:46: gettext: _ markup: All messages should be marked up with _.
> gdb/common/signals-state-save-restore.c:46: perror_with_name ("sigprocmask");
>> gdb/common/signals-state-save-restore.c:59: gettext: _ markup: All messages should be marked up with _.
> gdb/common/signals-state-save-restore.c:59: perror_with_name ("sigaction");
>> gdb/common/signals-state-save-restore.c:87: gettext: _ markup: All messages should be marked up with _.
> gdb/common/signals-state-save-restore.c:87: perror_with_name ("sigaction");
>> gdb/common/signals-state-save-restore.c:92: gettext: _ markup: All messages should be marked up with _.
> gdb/common/signals-state-save-restore.c:92: perror_with_name ("sigprocmask");
>
Fixed with the patch below. Master and 7.12 branch.
-----------
>From 9be00a778d646d92b7940d74425b58d93cb73d0d Mon Sep 17 00:00:00 2001
From: Pedro Alves <palves@redhat.com>
Date: Wed, 10 Aug 2016 16:07:43 +0100
Subject: [PATCH] Quiet ARI gettext checks
The ARI complains about this new file:
common/signals-state-save-restore.c:46: warning: gettext: All messages should be marked up with _.
common/signals-state-save-restore.c:59: warning: gettext: All messages should be marked up with _.
common/signals-state-save-restore.c:87: warning: gettext: All messages should be marked up with _.
common/signals-state-save-restore.c:92: warning: gettext: All messages should be marked up with _.
Since these are untranslatable strings, use () instead of _().
gdb/ChangeLog:
2016-08-10 Pedro Alves <palves@redhat.com>
* common/signals-state-save-restore.c
(save_original_signals_state, restore_original_signals_state):
Wrap perror_with_name arguments with '()'.
---
gdb/ChangeLog | 6 ++++++
gdb/common/signals-state-save-restore.c | 8 ++++----
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index eca96db..80c28c9 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2016-08-10 Pedro Alves <palves@redhat.com>
+
+ * common/signals-state-save-restore.c
+ (save_original_signals_state, restore_original_signals_state):
+ Wrap perror_with_name arguments with '()'.
+
2016-08-09 Pedro Alves <palves@redhat.com>
PR gdb/20418
diff --git a/gdb/common/signals-state-save-restore.c b/gdb/common/signals-state-save-restore.c
index 1c00cdd..5269062 100644
--- a/gdb/common/signals-state-save-restore.c
+++ b/gdb/common/signals-state-save-restore.c
@@ -43,7 +43,7 @@ save_original_signals_state (void)
res = sigprocmask (0, NULL, &original_signal_mask);
if (res == -1)
- perror_with_name ("sigprocmask");
+ perror_with_name (("sigprocmask"));
for (i = 1; i < NSIG; i++)
{
@@ -56,7 +56,7 @@ save_original_signals_state (void)
continue;
}
else if (res == -1)
- perror_with_name ("sigaction");
+ perror_with_name (("sigaction"));
/* If we find a custom signal handler already installed, then
this function was called too late. */
@@ -84,11 +84,11 @@ restore_original_signals_state (void)
continue;
}
else if (res == -1)
- perror_with_name ("sigaction");
+ perror_with_name (("sigaction"));
}
res = sigprocmask (SIG_SETMASK, &original_signal_mask, NULL);
if (res == -1)
- perror_with_name ("sigprocmask");
+ perror_with_name (("sigprocmask"));
#endif
}
--
2.5.5