This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Fix PR gdb/18653: gdb disturbs inferior's inherited signal dispositions

On Friday, August 05, 2016 11:56:56 AM Pedro Alves wrote:
> On 08/05/2016 02:04 AM, Pedro Alves wrote:
> > On 08/04/2016 07:37 PM, John Baldwin wrote:
> > 
> >> Perhaps consider saving/restore the entire 'struct sigaction' instead
> >> of just the sa_handler field given you are already requiring sigaction?
> > 
> > Indeed, I think I should, because signal masks are not reset
> > at exec time either.  Forgot about that.  Thanks for suggesting this.
> > 
> > I'll give it a try soon.
> > 
> 
> Like this?  
> 
> I renamed the new files and functions to avoid "disposition" since this
> saves/restores more than than now. I also applied a bit more polish to
> comments and error handling.

Yep.  Thanks, looks good to me.

-- 
John Baldwin
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]