This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] PR python/18565 - make Frame.function work for inline frames
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, Yao Qi <qiyaoltc at gmail dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 3 Aug 2016 18:57:44 +0100
- Subject: Re: [RFA] PR python/18565 - make Frame.function work for inline frames
- Authentication-results: sourceware.org; auth=none
- References: <1466439050-11330-1-git-send-email-tom@tromey.com> <86ziqfq6sz.fsf@gmail.com> <8737o5kqtv.fsf@tromey.com> <CAH=s-PMf2Encmm7JFLBDdrP6e07fEddCiVZGEfU+rkrunbSm-A@mail.gmail.com> <d861e87d-a94d-5ae9-5d51-3f7f8ad0ccc1@redhat.com> <87bn1lu5h9.fsf@tromey.com> <5ab877f8-9e39-6e02-2ece-46fcbcdacc0a@redhat.com> <CAH=s-PNWibRbzTeNfROd9fR=Y-Pn7zkFDwZpPAnyuW9rDKCmGw@mail.gmail.com> <87eg65lwb2.fsf@tromey.com>
On 08/03/2016 04:13 PM, Tom Tromey wrote:
>>>>>> "Yao" == Yao Qi <qiyaoltc@gmail.com> writes:
>
>>> In any case, IMO this would be the subject of a separate patch.
>
> Yao> This is the prerequisite of Tom's patch, no? It guarantees that *FUNNAME
> Yao> is not allocated if exception is thrown, otherwise *FUNAME is allocated.
> Yao> Tom's patch relies on this behaviour.
>
> Yao> I am OK with Tom's original patch, but we need to fix find_frame_funname
> Yao> first.
>
> Here's a patch. Please review.
>
LGTM.
> I'd like to check this and the other into the 7.12 branch as well.
Thanks,
Pedro Alves