This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 5/6] Remove unused variables
- From: Tom Tromey <tom at tromey dot com>
- To: "Maciej W. Rozycki" <macro at imgtec dot com>
- Cc: Tom Tromey <tom at tromey dot com>, Yao Qi <qiyaoltc at gmail dot com>, "gdb-patches\@sourceware.org" <gdb-patches at sourceware dot org>
- Date: Wed, 20 Jul 2016 13:48:59 -0600
- Subject: Re: [RFA 5/6] Remove unused variables
- Authentication-results: sourceware.org; auth=none
- References: <1465248812-23902-1-git-send-email-tom@tromey.com> <1465248812-23902-6-git-send-email-tom@tromey.com> <CAH=s-PMvtHAGGy-DQb_0qFRwuxfrg724i_yY3+qJzYnqgjixhQ@mail.gmail.com> <87wpl9t4l2.fsf@tromey.com> <CAH=s-PN+RJyhxRAgqM05hW97cTMzAn_rUQutxfJDrAJHPm-RqQ@mail.gmail.com> <87furdnubd.fsf@tromey.com> <alpine.DEB.2.00.1607201848070.4076@tp.orcam.me.uk>
Maciej> Of course one could argue that keeping broken code (though in a manner
Maciej> harmless to irrelevant cases) has little value, but at least it serves as
Maciej> a reminder to do something about it sometime.
I think on the whole it's preferable to file a bug for such cases; or to
comment out the offending code and put in an explanation. The warnings
catch real bugs; but they are not as useful if they are noisy.
Tom